Ensure files exist for install:broadcasting
#51719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, there are some other edge-cases which existed for this command, like the assumed namespace, location, and registry of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although closed, this addresses Issue #51157. The
install:broadcastinghas some legacy code which assumes the existence ofconfig/app.phpandapp/Providers/BroadcastServiceProvider.php. Neither may be true within a Laravel 11 application.This PR simply checks for the existence of these files before attempting to read a presumably legacy
config/app.phpto uncomment the legacy reference toBroadcastServiceProvider.Ideally, the
enableBroadcastServiceProvidermethod would be removed as it is not needed within a modern Laravel 11 application. But I left it to maintain support for older, unslimmed applications which are now running Laravel 11.